Skip to content

Commit

Permalink
Merge pull request #44 from carpentries/disable-search
Browse files Browse the repository at this point in the history
disable search
  • Loading branch information
zkamvar authored Jun 10, 2022
2 parents bcc8557 + 43cd059 commit ab9dad3
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 2 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: varnish
Title: Front-end for The Carpentries Lesson Template
Version: 0.1.14
Version: 0.1.15
Authors@R: c(
person(given = "Zhian N.",
family = "Kamvar",
Expand Down
7 changes: 7 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
# varnish 0.1.15

* The search field has been disabled to avoid confusion. We have not yet enabled
search as this requires further testing. Disabling the search field means that
it is now more clear that search is not yet available.
(#44 by @zkamvar)

# varnish 0.1.14

* indicators for lesson development stage (pre-alpha, alpha, beta) have been
Expand Down
9 changes: 8 additions & 1 deletion inst/pkgdown/templates/header.html
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,9 @@
{{#site}}{{title}}{{/site}}
</div>
<div class="search-icon-sm">
<!-- TODO: do not show until we have search
<i role="img" aria-label="search button" data-feather="search"></i>
-->
</div>
<div class="desktop-nav">
<ul class="navbar-nav me-auto mb-2 mb-lg-0">
Expand Down Expand Up @@ -135,7 +137,12 @@
</ul>
</div>
<form class="d-flex col-md-2 search-form">
<input class="form-control me-2 searchbox" type="search" placeholder="Search" aria-label="Search"> <button class="btn btn-outline-success tablet-search-button" type="submit"><i class="search-icon" data-feather="search" role="img" aria-label="search button"></i></button>
<fieldset disabled>
<input class="form-control me-2 searchbox" type="search" placeholder="Search" aria-label="Search">
<button class="btn btn-outline-success tablet-search-button" type="submit">
<i class="search-icon" data-feather="search" role="img" aria-label="search button"></i>
</button>
</fieldset>
</form>
</div><!--/div.container-fluid -->
</nav>
Expand Down

0 comments on commit ab9dad3

Please sign in to comment.