Merge pull request #366 from carpentries/fix-364

fix index title to be clear for learner view

NEWS.md

@@ -8,6 +8,12 @@ MISC
 * Documentation for automated pull requests updated to reflect bots should have
   `public_repo` scope.
 
+BUG FIX
+-------
+
+* A bug where the index page title was the same for both instructor and learner
+  view has been fixed (reported: @tobyhodges, #361; fixed @zkamvar, #366)
+
 # sandpaper 0.10.7
 
 CONTINUOUS INTEGRATION

R/build_home.R

@@ -22,8 +22,9 @@ build_home <- function(pkg, quiet, sidebar = NULL, new_setup = TRUE, next_page =
   fix_nodes(setup)
 
   nav <- get_nav_data(idx_file, fs::path_file(idx_file), page_forward = next_page)
+  needs_title <- nav$pagetitle == ""
 
-  if (nav$pagetitle == "") {
+  if (needs_title) {
     nav$pagetitle <- "Summary and Schedule"
   }
   nav$page_forward <- as_html(nav$page_forward, instructor = TRUE)
@@ -32,7 +33,7 @@ build_home <- function(pkg, quiet, sidebar = NULL, new_setup = TRUE, next_page =
   page_globals$instructor$set("readme", use_instructor(html))
   page_globals$instructor$set("setup", use_instructor(setup))
 
-  if (nav$pagetitle == "") {
+  if (needs_title) {
     nav$pagetitle <- "Summary and Setup"
   }
   nav$page_forward <- as_html(nav$page_forward)