Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention caution divs & include keywords for callout+spoiler fenced divs #458

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

tobyhodges
Copy link
Member

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Resolves #457 by making clearer what keywords should be used for the callout, spoiler, and caution fenced divs.

Copy link

github-actions bot commented Dec 3, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries/lesson-development-training/compare/md-outputs..md-outputs-PR-458

The following changes were observed in the rendered markdown documents:

 lesson-content.md | 22 +++++++++-------------
 md5sum.txt        |  2 +-
 2 files changed, 10 insertions(+), 14 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-12-03 08:52:16 +0000

@tobyhodges
Copy link
Member Author

This will also partially address #442, by mentioning the caution class of fenced div

@anenadic anenadic merged commit 5b7e57e into main Dec 4, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
Auto-generated via `{sandpaper}`
Source  : 5b7e57e
Branch  : main
Author  : Aleksandra Nenadic <[email protected]>
Time    : 2024-12-04 08:55:56 +0000
Message : Merge pull request #458 from carpentries/457-div-keywords

Mention caution divs & include keywords for callout+spoiler fenced divs
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
Auto-generated via `{sandpaper}`
Source  : 8417d1f
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-12-04 08:56:34 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 5b7e57e
Branch  : main
Author  : Aleksandra Nenadic <[email protected]>
Time    : 2024-12-04 08:55:56 +0000
Message : Merge pull request #458 from carpentries/457-div-keywords

Mention caution divs & include keywords for callout+spoiler fenced divs
@anenadic anenadic deleted the 457-div-keywords branch December 4, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add codetext examples for additional callout types
2 participants