-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] CLDT seat implementation #2689
base: develop
Are you sure you want to change the base?
Changes from all commits
b00cd6c
5eb218a
a0ec5a7
37303cd
bc7c4b3
4665d17
31a6b92
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,12 +16,16 @@ | |
<th rowspan="2">Agreement</th> | ||
<th rowspan="2">Contribution</th> | ||
<th colspan="3" class="text-center">Instructor training seats (combined public and in-house)</th> | ||
<th colspan="3" class="text-center">CLDT seats</th> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done! |
||
<th rowspan="2" class="additional-links"></th> | ||
</tr> | ||
<tr> | ||
<th>Total</th> | ||
<th>Utilized</th> | ||
<th>Remaining</th> | ||
<th>Total</th> | ||
<th>Utilized</th> | ||
<th>Remaining</th> | ||
</tr> | ||
{% for result in data %} | ||
<tr> | ||
|
@@ -35,6 +39,9 @@ | |
<td>{{ result.instructor_training_seats_total }}</td> | ||
<td>{{ result.instructor_training_seats_utilized }}</td> | ||
<td>{{ result.instructor_training_seats_remaining }}</td> | ||
<td>{{ result.cldt_seats_total_annotation }}</td> | ||
<td>{{ result.cldt_seats_utilized_annotation }}</td> | ||
<td>{{ result.cldt_seats_remaining_annotation }}</td> | ||
<td> | ||
<a href="{% url 'membership_details' result.pk %}" title="View membership"><i class="fas fa-info-circle"></i></a> | ||
</td> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,3 +5,6 @@ | |
STR_LONG = 100 # length of long strings | ||
STR_LONGEST = 255 # length of the longest strings | ||
STR_REG_KEY = 20 # length of Eventbrite registration key | ||
|
||
CLDT_TAG_NAME = ["CLDT"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd keep this plural ( |
||
TTT_TAG_NAMES = ["TTT", "ITT"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
# Generated by Django 4.2.13 on 2024-08-21 10:32 | ||
|
||
from django.db import migrations, models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
("workshops", "0270_alter_organization_affiliated_organizations"), | ||
] | ||
|
||
operations = [ | ||
migrations.AddField( | ||
model_name="event", | ||
name="open_CLDT_applications", | ||
field=models.BooleanField( | ||
blank=True, | ||
default=False, | ||
help_text="If this event is <b>CLDT</b>, you can mark it as 'open applications' which means that people not associated with this event's member sites can also take part in this event.", | ||
verbose_name="CLDT Open applications", | ||
), | ||
), | ||
migrations.AddField( | ||
model_name="membership", | ||
name="additional_cldt_seats", | ||
field=models.PositiveIntegerField( | ||
default=0, | ||
help_text="Use this field if you want to grant more CLDT seats than the agreement provides for.", | ||
verbose_name="Additional CLDT seats", | ||
), | ||
), | ||
migrations.AddField( | ||
model_name="membership", | ||
name="cldt_seats", | ||
field=models.PositiveIntegerField( | ||
default=0, | ||
help_text="Number of CLDT seats", | ||
verbose_name="Collaborative Lesson Development Training seats", | ||
), | ||
), | ||
migrations.AddField( | ||
model_name="membership", | ||
name="cldt_seats_rolled_from_previous", | ||
field=models.PositiveIntegerField( | ||
blank=True, | ||
help_text="CLDT seats rolled over from previous membership.", | ||
null=True, | ||
), | ||
), | ||
migrations.AddField( | ||
model_name="membership", | ||
name="cldt_seats_rolled_over", | ||
field=models.PositiveIntegerField( | ||
blank=True, | ||
help_text="CLDT seats rolled over into next membership.", | ||
null=True, | ||
), | ||
), | ||
migrations.AlterField( | ||
model_name="membership", | ||
name="public_status", | ||
field=models.CharField( | ||
choices=[("public", "Public"), ("private", "Private")], | ||
default="private", | ||
help_text="Public memberships may be listed on any of The Carpentries websites.", | ||
max_length=20, | ||
verbose_name="Can this membership be publicized on The Carpentries websites?", | ||
), | ||
), | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This notation (
remaining count
/total count
) is clever, but I'm wondering if users would know this is remaining / total, and not utilized / total.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check this with the CT, but as these calculations have been in place for the other seat types, I wouldn't want to change it without consulting them.