-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to glimmer-scoped-css 0.7.0 #1721
base: main
Are you sure you want to change the base?
Conversation
Host Test Results 1 files ± 0 1 suites ±0 15m 1s ⏱️ - 5m 22s For more details on these failures and errors, see this check. Results for commit 6f8976e. ± Comparison against base commit b0bbab5. This pull request removes 706 and adds 6 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
# Conflicts: # packages/boxel-ui/addon/rollup.config.mjs # packages/host/package.json # packages/realm-server/package.json # pnpm-lock.yaml
This doesn’t help, unsurprisingly, but no harm either.
I pushed a commit here that I hope helps unblock things:
The thing to know about keepAssets does not currently look inside CSS files to recursively identify more assets that need to be kept. That would be a good feature to add. That would eliminate the need for this kind of workaround. Alternatively, one can use the |
Thanks, I did have the unstable version before, I removed it in b85c6b0 not realising the changes needed haven’t been included in a release yet. What’s a good way to track this? I posted in the Ember Discord but in case you have an idea, the |
This doesn’t work, there must be configuration missing or something as
boxel-ui
no longer hasstyles/global.css
indist
, which causes thehost
build to fail.But it does fix that components in
boxel-ui
can have images in their CSS that gets copied intodist
.