Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIP-0129 | Improve gov action id description and examples clarity #987

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CIP-0129 | Improve gov action id description and examples clarity #987

wants to merge 1 commit into from
+28 −15

Conversation

Ryun1
Copy link
Collaborator

@Ryun1 Ryun1 commented Feb 7, 2025 •
edited
Loading

Problem

  • The formatting of the governance action id examples made them hard to follow

Changes

  • Removed abbreviations
  • Made capatalizion consistent
  • Fixed formatting of examples so not all rendered on one line
  • Added 'original id' to examples

@Ryun1 Ryun1 added the Correction Fixing minor issue or typo label Feb 7, 2025
@rphair rphair added State: Last Check Review favourable with disputes resolved; staged for merging. Category: Tools Proposals belonging to the 'Tools' category. labels Feb 7, 2025
@rphair rphair changed the title CIP-129 | improve gov action id description and examples clarity CIP-0129 | Improve gov action id description and examples clarity Feb 7, 2025
rphair
rphair reviewed Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Ryun1 ... marked Last Check but @perturbing @Crypto2099 if you think this is subject to review please say so and/or mark it back to Triage (from my point of view this is straightforwardly correct & useful).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rphair rphair rphair approved these changes

@Crypto2099 Crypto2099 Awaiting requested review from Crypto2099

@perturbing perturbing Awaiting requested review from perturbing

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Category: Tools Proposals belonging to the 'Tools' category. Correction Fixing minor issue or typo State: Last Check Review favourable with disputes resolved; staged for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ryun1 @rphair