feat(batch-jobs): Add step to pass API server env vars to spark jobs #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadlycoconuts
commented
Jan 6, 2025
deadlycoconuts
requested review from
mbruner,
shydefoo,
bthari and
vinoth-gojek
vinoth-gojek
approved these changes
Jan 7, 2025
|
Thanks a lot for the quick review! Merging this now! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Similar to caraml-dev/merlin#624, this simple PR simply adds a tiny feature to allow the API server to pass certain pre-configured environment variable values from its environment to the Spark drivers and executors (for batch prediction) that it spins up.
Modifications
api/turing/cluster/spark.go- Addition of a step to add pre-configured API server environment variables to the Spark driver/executor manifestapi/turing/config/config.go- Addition of a new config field to specify the environment values mentioned above