fix(api): Add configmaps as a resource to the spark driver role rules #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadlycoconuts
requested review from
mbruner,
shydefoo,
bthari and
vinoth-gojek
mbruner
requested changes
Jan 3, 2025
deadlycoconuts
force-pushed
the
add_config_maps_to_spark_driver_role
branch
from
a5a9f25 to
94592bc
Compare
mbruner
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Similar to caraml-dev/merlin#623, currently, the Spark driver service account that is created for every batch ensembling job does not have permissions to create ConfigMaps that its Spark executor(s) require(s). This is a problem in clusters with RBAC enabled and this PR simply adds the missing rule on ConfigMap resources for the Spark driver service account.
Modifications
api/turing/cluster/spark.go- Addition of configmaps as an additional rule