Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/nested/manual/remodel-uc20-to-uc22: remove encrypted case #15024

Merged
merged 1 commit into from
Feb 4, 2025
Merged

tests/nested/manual/remodel-uc20-to-uc22: remove encrypted case #15024

merged 1 commit into from
Feb 4, 2025

Conversation

valentindavid
Copy link
Contributor

The encrypted case is more complex and is covered in tests/nested/manual/remodel-uc-to-next-version-fakestore

@valentindavid
tests/nested/manual/remodel-uc20-to-uc22: remove encrypted case
d5ee0a1 
The encrypted case is more complex and is covered in
tests/nested/manual/remodel-uc-to-next-version-fakestore
@valentindavid valentindavid added Run nested The PR also runs tests inluded in nested suite FDE Manager Pull requests that target FDE manager branch labels Feb 4, 2025
pedronis
pedronis approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@pedronis pedronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

alfonsosanchezbeato
alfonsosanchezbeato approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@alfonsosanchezbeato alfonsosanchezbeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Tue Feb 4 18:47:59 UTC 2025
The following results are from: https://github.com/canonical/snapd/actions/runs/13139064215

Failures:

Preparing:

  • google-nested:ubuntu-20.04-64:tests/nested/manual/uc-update-assets-secure:seed
  • google-nested:ubuntu-20.04-64:tests/nested/manual/uc-update-assets-secure:both
  • google-nested:ubuntu-20.04-64:tests/nested/manual/minimal-smoke:secboot_enabled
  • google-nested:ubuntu-20.04-64:tests/nested/manual/recovery-system:default
  • google-nested:ubuntu-20.04-64:tests/nested/manual/remodel-target-base-installed
  • google-nested:ubuntu-20.04-64:tests/nested/manual/remodel-simple:offline
  • google-nested:ubuntu-20.04-64:tests/nested/manual/uc20-install-in-initrd:none
  • google-nested:ubuntu-20.04-64:tests/nested/manual/recovery-system-offline:pre_installed_snaps
  • google-nested:ubuntu-22.04-64:tests/nested/core/core22-basic:tokens
  • google-nested:ubuntu-22.04-64:tests/nested/core/interfaces-custom-devices
  • google-nested:ubuntu-22.04-64:tests/nested/manual/recovery-system-reboot:factory_reset
  • google-nested:ubuntu-22.04-64:tests/nested/manual/recovery-system-reboot:recover
  • google-nested:ubuntu-24.04-64:tests/nested/manual/build-with-kernel-modules-components:encrypted
  • google-nested:ubuntu-24.04-64:tests/nested/manual/remodel-simple:offline
  • google-nested:ubuntu-24.04-64:tests/nested/manual/hybrid-remodel
  • google-nested:ubuntu-24.04-64:tests/nested/manual/recovery-system-reboot:recover
  • google-nested:ubuntu-24.04-64:tests/nested/manual/uc20-fde-hooks:tokens
  • google-nested:ubuntu-24.04-64:tests/nested/manual/core20-fault-inject-on-install-component:kernel_panic_prepare_kernel_components
  • google-nested:ubuntu-24.04-64:tests/nested/manual/kernel-modules-components:encrypted
  • google-nested:ubuntu-24.04-64:tests/nested/manual/recovery-system-reboot:factory_reset
  • google-pro:ubuntu-fips-22.04-64

Executing:

  • google-nested:ubuntu-20.04-64:tests/nested/manual/remodel-offline:local_assertions
  • google-nested:ubuntu-20.04-64:tests/nested/manual/remodel-offline:installed_snaps
  • google-nested:ubuntu-20.04-64:tests/nested/manual/remodel-offline:local_and_installed_snaps
  • google-nested:ubuntu-22.04-64:tests/nested/core/core20-fault-inject-on-refresh:gadget_panic_auto_connect
  • google-nested:ubuntu-22.04-64:tests/nested/manual/muinstaller-real:plain
  • google-nested:ubuntu-22.04-64:tests/nested/manual/muinstaller-real:encrypted
  • google-nested:ubuntu-24.04-64:tests/nested/core/core22-basic:tokens
  • google-nested:ubuntu-24.04-64:tests/nested/core/core20-fault-inject-on-refresh:kernel_reboot_refresh_gadget_assets
  • google-nested:ubuntu-24.04-64:tests/nested/core/core20-fault-inject-on-refresh:base_reboot_link_snap
  • google-nested:ubuntu-24.04-64:tests/nested/manual/remodel-min-size
  • google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-real:seeded
  • google-nested:ubuntu-24.04-64:tests/nested/manual/uc-update-assets-secure:boot

Restoring:

  • google-nested:ubuntu-22.04-64:tests/nested/manual/muinstaller-real:plain
  • google-nested:ubuntu-22.04-64:tests/nested/manual/
  • google-nested:ubuntu-22.04-64
  • google-nested:ubuntu-22.04-64:tests/nested/manual/muinstaller-real:encrypted
  • google-nested:ubuntu-22.04-64:tests/nested/manual/
  • google-nested:ubuntu-22.04-64
  • google-nested:ubuntu-24.04-64:tests/nested/manual/uc-update-assets-secure:boot
  • google-nested:ubuntu-24.04-64:tests/nested/manual/
  • google-nested:ubuntu-24.04-64
  • google-nested:ubuntu-24.04-64:tests/nested/manual/core20-fault-inject-on-install-component:kernel_panic_prepare_kernel_components
  • google-nested:ubuntu-24.04-64:tests/nested/manual/
  • google-nested:ubuntu-24.04-64
  • google-nested:ubuntu-24.04-64:tests/nested/manual/kernel-modules-components:encrypted
  • google-nested:ubuntu-24.04-64:tests/nested/manual/
  • google-nested:ubuntu-24.04-64
  • google-nested:ubuntu-24.04-64:tests/nested/manual/recovery-system-reboot:factory_reset
  • google-nested:ubuntu-24.04-64:tests/nested/manual/
  • google-nested:ubuntu-24.04-64
  • google-pro:ubuntu-fips-22.04-64

@pedronis pedronis merged commit 6396453 into canonical:fde-manager-features Feb 4, 2025
58 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedronis pedronis pedronis approved these changes

@alfonsosanchezbeato alfonsosanchezbeato alfonsosanchezbeato approved these changes

Assignees
No one assigned
Labels
FDE Manager Pull requests that target FDE manager branch Run nested The PR also runs tests inluded in nested suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valentindavid @pedronis @alfonsosanchezbeato