Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

many: handle components during an offline remodel #15009

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

andrewphelpsj
Copy link
Member

@andrewphelpsj andrewphelpsj commented Jan 31, 2025

This change enables us to remodel in an offline context, while including components.

@github-actions github-actions bot added the Needs Documentation -auto- Label automatically added which indicates the change needs documentation label Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 85.98131% with 15 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@4be46eb). Learn more about missing BASE report.
Report is 65 commits behind head on master.

Files with missing lines Patch % Lines
daemon/api_model.go 76.92% 6 Missing and 3 partials ⚠️
overlord/devicestate/devicestate.go 91.04% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #15009   +/-   ##
=========================================
  Coverage          ?   78.23%           
=========================================
  Files             ?     1163           
  Lines             ?   154417           
  Branches          ?        0           
=========================================
  Hits              ?   120810           
  Misses            ?    26168           
  Partials          ?     7439           
Flag Coverage Δ
unittests 78.23% <85.98%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndyer ndyer added this to the 2.68 milestone Jan 31, 2025
Copy link

github-actions bot commented Jan 31, 2025

Tue Feb 4 17:55:20 UTC 2025
The following results are from: https://github.com/canonical/snapd/actions/runs/13137815543

Failures:

Executing:

  • google:ubuntu-20.04-64:tests/main/lxd:snapd_cgroup_neither

@andrewphelpsj andrewphelpsj force-pushed the remodel-components-offline branch from 37565a9 to 542666a Compare January 31, 2025 21:23
@andrewphelpsj andrewphelpsj force-pushed the remodel-components-offline branch from 542666a to 50c94e7 Compare February 4, 2025 14:10
@andrewphelpsj andrewphelpsj marked this pull request as ready for review February 4, 2025 14:10
@andrewphelpsj andrewphelpsj force-pushed the remodel-components-offline branch from 50c94e7 to 455bdc6 Compare February 4, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Documentation -auto- Label automatically added which indicates the change needs documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants