secboot: check legacy path for keyring when reading the primary key #14966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentindavid
added
Run nested
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fde-manager-features #14966 +/- ##
=======================================================
Coverage ? 78.14%
=======================================================
Files ? 1174
Lines ? 156057
Branches ? 0
=======================================================
Hits ? 121951
Misses ? 26545
Partials ? 7561
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
valentindavid
requested review from
pedronis and
bboozzoo
and removed request for
pedronis
pedronis
approved these changes
Jan 23, 2025
secboot/secboot_sb.go
Outdated
| } | ||
|
|
||
| // GetPrimaryKeyDigest retrieve the primary key for a disk from the | ||
| // keyring and returns it digest. If the path given does not match |
valentindavid
force-pushed
the
valentindavid/fallback-partuuid
branch
from
05b58eb to
2ae271a
Compare
bboozzoo
approved these changes
Jan 24, 2025
valentindavid
force-pushed
the
valentindavid/fallback-partuuid
branch
from
2ae271a to
b0a5f1f
Compare
pedronis
force-pushed
the
fde-manager-features
branch
from
7005c64 to
25f9119
Compare
valentindavid
force-pushed
the
valentindavid/fallback-partuuid
branch
from
b0a5f1f to
413aad0
Compare
|
Tue Feb 4 13:31:33 UTC 2025 Failures:Preparing:
Executing:
Restoring:
|
valentindavid
force-pushed
the
valentindavid/fallback-partuuid
branch
2 times, most recently
from
8bdf5da to
112b128
Compare
In the case we update snapd with and old kernel, then reseal, the FDE state might be not set because we did not find the primary key from the initrd that set it in the legacy path. So if we do not find the key in the keyring, we should try and see if we find it in the old path.
valentindavid
force-pushed
the
valentindavid/fallback-partuuid
branch
from
112b128 to
2feea80
Compare
pedronis
merged commit 1c1b779
into
canonical:fde-manager-features
60 of 67 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.