Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix snapcraft build instructions and explicitly install lxd #14941

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

wheelerz
Copy link
Contributor

I was running through a build using current documentation in HACKING.md for building snapd with snapcraft and it doesn't work in 24.04 (or 22.04). It also doesn't mention the lxd requirement, which leads to uncertainty about the build process when lxd asks many config questions and isn't mentioned in the build instructions. This documentation change:

  • Adds --classic flag to snap install for snapcraft, as it is required
  • Removes --channel option from snapcraft call as it no longer exists in 8.5.1
  • Adds necessary and missing sudo to snap install
  • Makes the lxd install and lxd init step explicit

…requisite

The current documentation for building snapd with snapcraft doesn't work in 24.04. It also doesn't
mention the LXD requirement, which leads to uncertainty about the build process when lxd asks many
config questions and isn't mentioned in the build instructions. This documentation change:
- Adds --classic flag to snap install for snapcraft, as it is required
- Removes --channel option from snapcraft call as it no longer exists in 8.5.1
- Adds necessary and missing sudo to snap install
- Makes the lxd install and lxd init step explicit
Copy link

github-actions bot commented Jan 16, 2025

Tue Feb 4 18:07:11 UTC 2025

Spread tests skipped

@wheelerz
Copy link
Contributor Author

I believe I have signed the contributor agreement for my GitHub user wheelerz, but it was only a few hours ago so I believe it has not gone through yet.

@Meulengracht Meulengracht added the Skip spread Indicate that spread job should not run label Jan 17, 2025
@Meulengracht Meulengracht reopened this Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@846e5de). Learn more about missing BASE report.
Report is 69 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #14941   +/-   ##
=========================================
  Coverage          ?   79.15%           
=========================================
  Files             ?     1164           
  Lines             ?   158154           
  Branches          ?        0           
=========================================
  Hits              ?   125188           
  Misses            ?    25563           
  Partials          ?     7403           
Flag Coverage Δ
unittests 79.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ernestl ernestl self-requested a review February 4, 2025 15:26
Copy link
Collaborator

@ernestl ernestl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ernestl
Copy link
Collaborator

ernestl commented Feb 4, 2025

Hi @wheelerz, do you have a Launchpad ID?
Do you mind trying again: https://ubuntu.com/legal/contributors/agreement

BTW, are use signing as individual or on behalf of organization?

@ernestl ernestl added this to the 2.68 milestone Feb 4, 2025
@wheelerz
Copy link
Contributor Author

wheelerz commented Feb 4, 2025

I am happy to try it again. My launchpad ID is zacwheeler

I am signing as an individual.

@wheelerz
Copy link
Contributor Author

wheelerz commented Feb 4, 2025

image

@miguelpires miguelpires closed this Feb 4, 2025
@miguelpires miguelpires reopened this Feb 4, 2025
Copy link
Contributor

@miguelpires miguelpires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@miguelpires miguelpires merged commit 1eb4898 into canonical:master Feb 4, 2025
125 of 126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip spread Indicate that spread job should not run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants