Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces/builtin: make checkbox-support exempt from device access mediation #14911

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bboozzoo
Copy link
Contributor

@bboozzoo bboozzoo commented Jan 9, 2025

Checkbox shoudl have unrestricted access to all devices.

Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?

…ediation

Checkbox shoudl have unrestricted access to all devices.

Signed-off-by: Maciej Borzecki <[email protected]>
@bboozzoo bboozzoo requested review from zyga and Meulengracht January 9, 2025 13:23
Copy link
Contributor

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I didn't think of device cgroups when looking at checkbox-support.

LGTM!

Copy link
Member

@Meulengracht Meulengracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 lets see tests

func init() {
registerIface(&checkboxSupportInterface{steamSupportInterface{commonInterface{
name: "checkbox-support",
summary: checkboxSupportSummary,
implicitOnCore: true,
implicitOnClassic: true,
controlsDeviceCgroup: true, // checkbox is exempt from device filtering
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants