core-initrd: fix some issues with ubuntu-core-initramfs package builds #14909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alfonsosanchezbeato
commented
Jan 8, 2025
alfonsosanchezbeato
commented
- Fix builds in launchpad
- Add changelog entries automatically
- Fix golang dependency
- Include snapd version and Ubuntu series in package version
Create new changelog entry when creating new ubuntu-core-initramfs debian source packages. Tweak the version so now it includes snapd version and Ubuntu series.
It was incorrectly a run dependecy.
Launchpad dos not allow change in the root of the debian package directory, create the go cache elsewhere.
alfonsosanchezbeato
added
the
Run nested
the ubuntu-core-initramfs source packages.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14909 +/- ##
==========================================
+ Coverage 78.20% 78.24% +0.03%
==========================================
Files 1151 1157 +6
Lines 151396 152828 +1432
==========================================
+ Hits 118402 119576 +1174
- Misses 25662 25869 +207
- Partials 7332 7383 +51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
valentindavid
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.