build-aux/snap/local: cleanup patch and verification helper scripts #14901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14901 +/- ##
==========================================
+ Coverage 78.20% 78.23% +0.02%
==========================================
Files 1151 1156 +5
Lines 151396 152851 +1455
==========================================
+ Hits 118402 119579 +1177
- Misses 25662 25891 +229
- Partials 7332 7381 +49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
valentindavid
approved these changes
Jan 8, 2025
build-aux/snap/snapcraft.yaml
Outdated
| @@ -524,4 +525,6 @@ parts: | |||
| <<: | |||
| - *dynamic-linker | |||
| override-prime: | | |||
| python3 "${CRAFT_PROJECT_DIR}/build-aux/snap/local/verify-dl.py" "${CRAFT_PRIME}" "/snap/snapd/current/usr/lib/${CRAFT_ARCH_TRIPLET_BUILD_FOR}/${DYNAMIC_LINKER}" ";" | |||
| "${CRAFT_PROJECT_DIR}/build-aux/snap/local/verify-dl.py" \ | |||
| "${CRAFT_PRIME}" \ | |||
There was a problem hiding this comment.
Maybe we could have taken the opportunity to read the environment variable if --prime is not passed like done in patch-dl.py. Just to make the command line smaller.
There was a problem hiding this comment.
updated the commit to account for this
bboozzoo
force-pushed
the
bboozzoo/improve-snap-build-helper-scripts
branch
from
ecdb967 to
63a8188
Compare
Improve the patching and verification scripts used during snap build. Signed-off-by: Maciej Borzecki <[email protected]>
Signed-off-by: Maciej Borzecki <[email protected]>
bboozzoo
force-pushed
the
bboozzoo/improve-snap-build-helper-scripts
branch
from
63a8188 to
360714b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the patching and verification scripts used during snap build.
Related: SNAPDENG-34352