many: support creating recovery systems with components from the store #14883
Conversation
github-actions
bot
added
the
Needs Documentation -auto-
andrewphelpsj
force-pushed
the
create-rec-system-components-from-store
branch
3 times, most recently
from
97dcdbc to
f5b4456
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14883 +/- ##
==========================================
+ Coverage 78.20% 78.23% +0.02%
==========================================
Files 1151 1155 +4
Lines 151396 152952 +1556
==========================================
+ Hits 118402 119659 +1257
- Misses 25662 25906 +244
- Partials 7332 7387 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrewphelpsj
force-pushed
the
create-rec-system-components-from-store
branch
from
f5b4456 to
ff1739f
Compare
andrewphelpsj
force-pushed
the
create-rec-system-components-from-store
branch
from
ff1739f to
44f4ac7
Compare
github-actions
bot
removed
the
Needs Documentation -auto-
andrewphelpsj
force-pushed
the
create-rec-system-components-from-store
branch
from
44f4ac7 to
24552e7
Compare
… creating recovery systems with components from the store
… that require snaps that are at least in the model
andrewphelpsj
force-pushed
the
create-rec-system-components-from-store
branch
from
8d163e4 to
e4735ed
Compare
| @@ -53,7 +53,7 @@ execute: | | |||
| boot_id="$(tests.nested boot-id)" | |||
|
|
|||
| # create the system | |||
| change_id=$(post_json_data /v2/systems '{"action": "create", "label": "new-system", "validation-sets": ["test-snapd/recovery-system-pinned=1"], "test-system": %s, "mark-default": %s}' "${TEST_SYSTEM}" "${MARK_DEFAULT}") | |||
| change_id=$(post_json_data /v2/systems '{"action": "create", "label": "new-system", "validation-sets": ["test-snapd/recovery-system-pinned=2"], "test-system": %s, "mark-default": %s}' "${TEST_SYSTEM}" "${MARK_DEFAULT}") | |||
There was a problem hiding this comment.
Why is this change needed?
There was a problem hiding this comment.
This was a bug in the test, found by me fixing a bug in the code. The old version of the validation set was requiring "core20", which doesn't make sense as this test is used on multiple systems with various bases.
overlord/devicestate/systems.go
Outdated
| // * passed into the task via a list of side infos (these would have | ||
| // come from a user posting components via the API) |
There was a problem hiding this comment.
Where is this case handled? I'm not sure if I see that in this method.
There was a problem hiding this comment.
That comment contains too much, this PR doesn't implement the offline case where we provide components. It'll be in the next one, but I'll fix this comment for now.
…creating recovery systems from locally provided components
This PR allows us to create recovery systems that contain components using the /v2/systems API.