Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: prepare memory limit before each test #14860

Merged

Conversation

maykathm
Copy link
Contributor

Occasionally, the mount order regression test would get the oom-killer called due to an imposed memory limit. That memory limit was incorrect applied due to the prepare_memory_limit_override not being called in the prepare-each.

@maykathm maykathm force-pushed the SNAPDENG-31426-fix-mount-order-regression branch from 991966c to 2b82ef4 Compare December 13, 2024 16:15
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.09%. Comparing base (24a0034) to head (daf16e8).
Report is 49 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14860      +/-   ##
==========================================
- Coverage   78.20%   78.09%   -0.12%     
==========================================
  Files        1151     1134      -17     
  Lines      151396   151301      -95     
==========================================
- Hits       118402   118156     -246     
- Misses      25662    25845     +183     
+ Partials     7332     7300      -32     
Flag Coverage Δ
unittests 78.09% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maykathm maykathm marked this pull request as ready for review December 14, 2024 07:07
tests/lib/prepare-restore.sh Outdated Show resolved Hide resolved
tests/lib/prepare-restore.sh Show resolved Hide resolved
Copy link
Member

@andrewphelpsj andrewphelpsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maykathm
Copy link
Contributor Author

Spread Failures:

centos - openstack allocation errors
debian-not-req - openstack allocation errors
fedora - openstack allocation errors
opensuse - openstack allocation errors
ubuntu-16 - degraded - unrelated known failure

@ndyer ndyer merged commit f036c4e into canonical:master Dec 18, 2024
53 of 59 checks passed
@maykathm maykathm deleted the SNAPDENG-31426-fix-mount-order-regression branch December 18, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants