-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update table.html styling for mobile view #1059
Open
chandrikarj
wants to merge
12
commits into
camicroscope:develop
Choose a base branch
from
chandrikarj:update-table.html-styling-for-mob-view
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update table.html styling for mobile view #1059
chandrikarj
wants to merge
12
commits into
camicroscope:develop
from
chandrikarj:update-table.html-styling-for-mob-view
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create stale_issues.yml
birm
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, this has an odd side effect on buttons when slides are loaded, and I think it's less usable:
Screen.Recording.2025-01-22.at.10.49.55.PM.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #738 : Styling adjustment needed in mobile view of table.html page
Summary
This pull request addresses the misalignment issue of the Collection, Reload, and DICOM buttons in the mobile view of table.html. The layout has been updated using CSS flex properties to maintain proper spacing, and provide a cleaner, user-friendly interface.
Changes include:
Adjusted CSS styling to align buttons for mobile view.
Implemented responsive design using media queries to target mobile screen sizes specifically.
Ensured no visual disruption to the desktop layout.
Video with the changes included:
Screen.Recording.2025-01-06.at.6.45.47.PM.mov
Before:
![Screenshot 2025-01-06 at 6 48 26 PM](https://private-user-images.githubusercontent.com/192535132/400433212-3f91c667-eeab-40f0-b02c-9f73895e6aa3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMTU5MDYsIm5iZiI6MTczOTAxNTYwNiwicGF0aCI6Ii8xOTI1MzUxMzIvNDAwNDMzMjEyLTNmOTFjNjY3LWVlYWItNDBmMC1iMDJjLTlmNzM4OTVlNmFhMy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQxMTUzMjZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zNzRlODg1MzFjYTgzNWZjYWI4MDkyNTZmYzRiZTU0YjZiMDI3OWNhZDA1NDQ2MmYwMDQzYTg4ZTZiOTM3YmNiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.aDQcJo3zlIreQOvr-6huCEKLXU6HgfeRxRHjfjdLlEI)
After:
![Screenshot 2025-01-06 at 6 49 47 PM](https://private-user-images.githubusercontent.com/192535132/400433519-c07e816e-2c1e-47d8-a3f3-92edc1688cf9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMTU5MDYsIm5iZiI6MTczOTAxNTYwNiwicGF0aCI6Ii8xOTI1MzUxMzIvNDAwNDMzNTE5LWMwN2U4MTZlLTJjMWUtNDdkOC1hM2YzLTkyZWRjMTY4OGNmOS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQxMTUzMjZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02MDc4M2ZiNDlmZjg5YjdhNmE4ZGYzZjUyNTlkODg0NzFjYTUxNGJhZWIwMzZiOTIxMjkzYjYyNGIzZjkyNDA3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Gx4RUjE7BSXdbomR8is3A_nQQ2Oi-71OvhO3ZkM0iEI)
Motivation
The current positioning of the Collection, Reload, and DICOM buttons in mobile view appears cluttered and unappealing. This PR enhances usability by improving button alignment and spacing.
Testing
Tested changes on:
-Mobile simulation: Google Chrome DevTools (Version 98.0.4758.102)
-Desktop simulation: Windows 10, Chrome responsive mode.