fix: Some errors breaking storybook build #18767
Open
+6
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cnhhoang850 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/20/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (01/20/25)1 label was added to this PR based on Keith Williams's automation. |
cnhhoang850
commented
Jan 20, 2025
cnhhoang850
commented
Jan 20, 2025
| @@ -9,8 +9,6 @@ const config: StorybookConfig = { | |||
| "../../../packages/ui/components/**/*.docs.mdx", | |||
| "../../../packages/features/**/*.stories.@(js|jsx|ts|tsx)", | |||
| "../../../packages/features/**/*.docs.mdx", | |||
| "../../../packages/atoms/**/*.stories.@(js|jsx|ts|tsx)", | |||
There was a problem hiding this comment.
Atoms not placed here anymore
cnhhoang850
commented
Jan 20, 2025
| @@ -11,7 +11,8 @@ module.exports = { | |||
| * These styles will only be added in storybook, and will NOT | |||
| * end up in the final css bundle of apps using the components. | |||
| */ | |||
| "postcss-pseudo-companion-classes": { | |||
| [require.resolve("postcss-pseudo-companion-classes")]: { | |||
There was a problem hiding this comment.
Needs to be resolved as absolute path
cnhhoang850
commented
Jan 20, 2025
| @@ -209,7 +209,7 @@ const EventTypeAppCard: EventTypeAppCardComponent = function EventTypeAppCard({ | |||
| <div>{t("value")}</div> | |||
| </div> | |||
| <div> | |||
| {...Object.keys(onBookingWriteToEventObjectMap).map((key) => ( | |||
There was a problem hiding this comment.
React disallows inline spread, isn't different from without spread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)