Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: technical debt clearing - remove getServerSideProps #18754

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: technical debt clearing - remove getServerSideProps #18754

wants to merge 2 commits into from

Conversation

tanayvaswani
Copy link

@tanayvaswani tanayvaswani commented Jan 19, 2025 •
edited
Loading

What does this PR do?

  • Removes getServerSideProps for /event-types/[type]
  • Removes EventTypePageWrapper event views
cal-test.mov

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code.
  • N/A
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Visit /event-types/[type]?tabName=setup (or any other tab) to test it

@vercel Vercel
Copy link

vercel bot commented Jan 19, 2025

@tanayvaswani is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jan 19, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tanayvaswani tanayvaswani marked this pull request as ready for review January 20, 2025 08:31
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 20, 2025
@graphite-app graphite-app bot requested a review from a team January 20, 2025 08:31
@dosubot dosubot bot added the event-types area: event types, event-types label Jan 20, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 20, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/20/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (01/20/25)

1 label was added to this PR based on Keith Williams's automation.

@anikdhabal anikdhabal requested a review from hbjORbj January 20, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbjORbj hbjORbj Awaiting requested review from hbjORbj

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
community Created by Linear-GitHub Sync event-types area: event types, event-types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanayvaswani @CLAassistant