perf: Use one PageWrapper instance for all settings pages #18752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move /403 and /500 * move /auth/error * move /connect-and-join * move /enterprise * move /maintenance * move /more * move /upgrade
…yout-from-more-multiple-pages
…yout-from-bookings-status-page
…to chore/removing-WithLayout-from-more-multiple-pages
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
hbjORbj
changed the base branch from
main
to
chore/removing-WithLayout-from-more-multiple-pages
hbjORbj
changed the title
settings/(settings-layout) and settings/(admin-layout)
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/19/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (01/19/25)1 reviewer was added to this PR based on Keith Williams's automation. |
hbjORbj
changed the title
settings/(settings-layout) and settings/(admin-layout)…o chore/removing-WithLayout-from-settings-pages
hbjORbj
changed the title
hbjORbj
added
the
performance
Base automatically changed from
chore/removing-WithLayout-from-more-multiple-pages
to
main
January 23, 2025 15:01
…yout-from-settings-pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
WithLayoutand relying on a single layout file. We need to migrate all routes that useWithLayoutinto(use-page-wrapper)route group.Mandatory Tasks (DO NOT REMOVE)
How should this be tested?