Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added ability to enforce ui language for an event (default behaviour: visitor's browser language) #18738

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: added ability to enforce ui language for an event (default behaviour: visitor's browser language) #18738

wants to merge 10 commits into from

Conversation

MehulZR
Copy link
Contributor

@MehulZR MehulZR commented Jan 17, 2025 •
edited
Loading

What does this PR do?

enforce.ui.lang.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel Vercel
Copy link

vercel bot commented Jan 17, 2025

@MehulZR is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added ❗️ migrations contains migration files booking-page area: booking page, public booking page, booker event types Created by Linear-GitHub Sync event-types area: event types, event-types i18n area: i18n, translations ui area: UI, frontend, button, form, input ✨ feature New feature or request 💎 Bounty A bounty on Algora.io labels Jan 17, 2025
@MehulZR MehulZR changed the title feat: added userInterfaceLanguage field to the EventType Table and selector for it in the Event type form feat: added ability to enforce ui language for an event (default behaviour: visitor's browser language) Jan 17, 2025
Praashh
Praashh suggested changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type Checks are failing, can you please that??

@MehulZR
Copy link
Contributor Author

MehulZR commented Jan 18, 2025

Type Checks are failing, can you please that??

PR is still in WIP.
Once the solution is proved working. I will finish it up.

@MehulZR MehulZR marked this pull request as ready for review January 22, 2025 01:05
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 22, 2025
@graphite-app graphite-app bot requested review from a team January 22, 2025 01:05
@dosubot dosubot bot added this to the v5.0 milestone Jan 22, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 22, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/22/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (01/22/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (01/22/25)

1 label was added to this PR based on Keith Williams's automation.

@MehulZR MehulZR requested a review from Praashh January 22, 2025 01:12
@MehulZR
Copy link
Contributor Author

MehulZR commented Jan 22, 2025

For the initial review, the PR changes are made for the Booker component only.

If the current approach feels valid in the review, I can quickly make changes for the Booking Confirmation page too.

Praashh
Praashh suggested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

production build is failing, @MehulZR can you please fix it 🙏

@MehulZR
Copy link
Contributor Author

MehulZR commented Jan 22, 2025

@Praashh It was not able to set up the db, due to the Docker Hub pull limit being exceeded.

image

@Praashh
Copy link
Contributor

Praashh commented Jan 23, 2025

@Praashh It was not able to set up the db, due to the Docker Hub pull limit being exceeded.

image

can you please tell me when did you get this error

@MehulZR
Copy link
Contributor Author

MehulZR commented Jan 23, 2025

@Praashh

logs.mp4

@Praashh
Copy link
Contributor

Praashh commented Jan 24, 2025

@Praashh

logs.mp4

am not aware of build pipelines, may be @anikdhabal can help here.

@MehulZR
Copy link
Contributor Author

MehulZR commented Jan 24, 2025

No worries, I will just merge with main and it will run again. 👍

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2025 •
edited
Loading

E2E results are ready!

@MehulZR MehulZR requested a review from Praashh January 24, 2025 17:08
@Praashh
Copy link
Contributor

Praashh commented Jan 25, 2025

@MehulZR can you please resolve merge conflicts ?

Praashh
Praashh reviewed Jan 25, 2025
View reviewed changes
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! thank you sir ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritiksharmarj ritiksharmarj ritiksharmarj left review comments

@Praashh Praashh Praashh approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
booking-page area: booking page, public booking page, booker 💎 Bounty A bounty on Algora.io community Created by Linear-GitHub Sync event types Created by Linear-GitHub Sync event-types area: event types, event-types ✨ feature New feature or request i18n area: i18n, translations ❗️ migrations contains migration files ready-for-e2e ui area: UI, frontend, button, form, input
Projects
None yet
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.

[CAL-5043] event-type: option to enforce a language for the booking page (default: visitors browser language)
3 participants
@MehulZR @Praashh @ritiksharmarj