Show pending events in history timeline #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/utils/data-formatters/schema/format-history-pending-event-schema.ts
Outdated
Show resolved
Hide resolved
...data-formatters/format-pending-workflow-history-event/format-pending-activity-start-event.ts
Outdated
Show resolved
Hide resolved
src/utils/data-formatters/format-pending-workflow-history-event/index.ts
Outdated
Show resolved
Hide resolved
) Add onClickItem handler to Timeline that gets called when the VisJS Timeline registers a click on an item Add "id" number to TimelineItem Set selected event in query params and scroll to it when an item is selected in the timeline Refactor Workflow Timeline Styles to share common styles across different items and states Added rounding to non-timer items Removed rounding from timer items
…-history-timeline
adhityamamallan
requested changes
Feb 11, 2025
src/utils/data-formatters/schema/format-history-pending-event-schema.ts
Outdated
Show resolved
Hide resolved
| const firstEvent = events[0]; | ||
|
|
||
| if (scheduleEvent) { | ||
| // getting group label |
There was a problem hiding this comment.
If it helps, you can move these to helpers instead of having a comment above explaining the code. Though tbh, I don't think you need to do either
There was a problem hiding this comment.
Yeah i think at some point we would need to extract individual processing functionalities to a separate helpers. I'm currently only extracting reusable ones for helpers and keeping others until a pattern is noticed. Also if we started to notice the grouping functions growing we can extract large code sections outside.
...ews/workflow-history/helpers/get-history-group-from-events/get-activity-group-from-events.ts
Show resolved
Hide resolved
src/views/workflow-history/helpers/pending-decision-info-to-event.ts
Outdated
Show resolved
Hide resolved
adhityamamallan
approved these changes
Feb 11, 2025
Assem-Uber
deleted the
feature/11701/show-pending-tasks-in-history-timeline
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Show pending history events in history timeline. This is done by transforming relevant pending information to an event and adding it to the correct group.
Changes
computedEventIdinstead ofeventIdfor selecting events with noeventIdScreenshots