Skip to content

Commit

Permalink
Merging from upstream master
Browse files Browse the repository at this point in the history
  • Loading branch information
sdwr98 committed Nov 13, 2020
1 parent dc1834e commit 238cdbf
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 22 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,8 @@
import com.uber.cadence.RespondActivityTaskFailedRequest;
import com.uber.cadence.WorkflowExecution;
import com.uber.cadence.context.ContextPropagator;

import com.uber.cadence.context.OpenTracingContextPropagator;

import com.uber.cadence.internal.common.RpcRetryer;

import com.uber.cadence.internal.logging.LoggerTag;
import com.uber.cadence.internal.metrics.MetricsTag;
import com.uber.cadence.internal.metrics.MetricsType;
Expand Down
1 change: 0 additions & 1 deletion src/main/java/com/uber/cadence/worker/Worker.java
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
import com.uber.cadence.workflow.WorkflowMethod;
import com.uber.m3.tally.Scope;
import com.uber.m3.util.ImmutableMap;

import java.time.Duration;
import java.util.List;
import java.util.Objects;
Expand Down
6 changes: 4 additions & 2 deletions src/test/java/com/uber/cadence/context/ContextTests.java
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import com.uber.cadence.activity.ActivityMethod;
import com.uber.cadence.activity.ActivityOptions;
import com.uber.cadence.client.WorkflowClient;
import com.uber.cadence.client.WorkflowClientOptions;
import com.uber.cadence.client.WorkflowException;
import com.uber.cadence.client.WorkflowOptions;
import com.uber.cadence.internal.testing.WorkflowTestingTest.ChildWorkflow;
Expand Down Expand Up @@ -81,13 +82,14 @@ protected void failed(Throwable e, Description description) {
public void setUp() {
TestEnvironmentOptions options =
new TestEnvironmentOptions.Builder()
.setFactoryOptions(
new Worker.FactoryOptions.Builder()
.setWorkflowClientOptions(
WorkflowClientOptions.newBuilder()
.setContextPropagators(
Arrays.asList(
new TestContextPropagator(), new OpenTracingContextPropagator()))
.build())
.build();

testEnvironment = TestWorkflowEnvironment.newInstance(options);
GlobalTracer.registerIfAbsent(mockTracer);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@

package com.uber.cadence.internal.testing;

import static org.junit.Assert.*;
import static org.mockito.Matchers.anyString;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

import com.uber.cadence.EventType;
import com.uber.cadence.GetWorkflowExecutionHistoryRequest;
import com.uber.cadence.History;
Expand Down Expand Up @@ -49,6 +54,13 @@
import com.uber.cadence.workflow.SignalMethod;
import com.uber.cadence.workflow.Workflow;
import com.uber.cadence.workflow.WorkflowMethod;
import java.time.Duration;
import java.util.List;
import java.util.Optional;
import java.util.UUID;
import java.util.concurrent.CancellationException;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutionException;
import org.apache.thrift.TException;
import org.junit.After;
import org.junit.Before;
Expand All @@ -60,19 +72,6 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.time.Duration;
import java.util.List;
import java.util.Optional;
import java.util.UUID;
import java.util.concurrent.CancellationException;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutionException;

import static org.junit.Assert.*;
import static org.mockito.Matchers.anyString;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

public class WorkflowTestingTest {
private static final Logger log = LoggerFactory.getLogger(WorkflowTestingTest.class);

Expand All @@ -95,9 +94,7 @@ protected void failed(Throwable e, Description description) {
public void setUp() {
TestEnvironmentOptions options =
new TestEnvironmentOptions.Builder()
.setWorkflowClientOptions(
WorkflowClientOptions.newBuilder()
.build())
.setWorkflowClientOptions(WorkflowClientOptions.newBuilder().build())
.build();
testEnvironment = TestWorkflowEnvironment.newInstance(options);
}
Expand Down

0 comments on commit 238cdbf

Please sign in to comment.