Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common] Introduce testlogger as a workaround of poor lifecycle #1398

Merged
merged 9 commits into from
Nov 11, 2024

add a nil case to ValueFromPtr

e209ff6
Select commit
Loading
Failed to load commit list.
Merged

[common] Introduce testlogger as a workaround of poor lifecycle #1398

add a nil case to ValueFromPtr
e209ff6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Nov 11, 2024 in 0s

95.00% of diff hit (target 85.00%)

View this Pull Request on Codecov

95.00% of diff hit (target 85.00%)

Annotations

Check warning on line 133 in internal/common/testlogger/testlogger.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/common/testlogger/testlogger.go#L133 

Added line #L133 was not covered by tests

Check warning on line 146 in internal/common/testlogger/testlogger.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/common/testlogger/testlogger.go#L144-L146 

Added lines #L144 - L146 were not covered by tests
View more details on Codecov