simply change

cadence-workflow · Jan 16, 2025 · f17dce3 · f17dce3
1 parent 5f75c34
commit f17dce3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/internal/internal_poller_autoscaler.go b/internal/internal_poller_autoscaler.go
@@ -174,9 +174,9 @@ func (m *pollerUsageEstimator) CollectUsage(data interface{}) error {
 func isTaskEmpty(task interface{}) (bool, error) {
 	switch t := task.(type) {
 	case *workflowTask:
-		return t == nil || isEmptyDecisionTask(t.task), nil
+		return t == nil || t.task == nil || len(t.task.TaskToken) == 0, nil
 	case *activityTask:
-		return t == nil || isEmptyActivityTask(t.task), nil
+		return t == nil || t.task == nil || len(t.task.TaskToken) == 0, nil
 	case *localActivityTask:
 		return t == nil || t.workflowTask == nil, nil
 	default:

diff --git a/internal/internal_utils.go b/internal/internal_utils.go
@@ -492,11 +492,3 @@ func getLengthOfStringPointer(s *string) int {
 	}
 	return len(*s)
 }
-
-func isEmptyDecisionTask(r *s.PollForDecisionTaskResponse) bool {
-	return r == nil || len(r.TaskToken) == 0
-}
-
-func isEmptyActivityTask(r *s.PollForActivityTaskResponse) bool {
-	return r == nil || len(r.TaskToken) == 0
-}