Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing name of s3 bucket since dev-cad' possession is released #180

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

dkrotx
Copy link
Member

@dkrotx dkrotx commented Mar 13, 2024

I believe we made this bucket while we were testing Archival feature.
It is not owned by Uber anymore, and it also may be misleading to have
the same mentioned.

Copy link
Contributor

@ibarrajo ibarrajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

I believe we made this bucket while we were testing Archival feature.
It is not owned by Uber anymore, and it also may be misleading to have
the same mentioned.
@dkrotx dkrotx force-pushed the fix-s3bucket-name branch from 9154189 to 1549c42 Compare March 14, 2024 22:20
@dkrotx dkrotx merged commit 009a548 into cadence-workflow:master Mar 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants