Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Manage Localization Settings #84

Closed
wants to merge 1 commit into from
Closed

Conversation

jbrooksuk
Copy link
Member

Closes #65

I'm still considering whether this is the right path or not. Does it make sense to have a "global" setting for date / timestamp formatting, or should it be possible to change individual settings - this could be more tedious though.

CleanShot 2024-10-04 at 13 44 21

@jbrooksuk jbrooksuk marked this pull request as draft October 5, 2024 10:05
@jbrooksuk
Copy link
Member Author

Also, I kind of think it'd be better to show timestamps in whatever the browser dictates as the best format for the visitor's locale...

@spoyntersmith
Copy link

spoyntersmith commented Oct 19, 2024

Also, I kind of think it'd be better to show timestamps in whatever the browser dictates as the best format for the visitor's locale...

Agree with this, as it means a user doesn't need to set the preference if it's not the same as the default, it will automatically follow their browser locale and preference with no effort.

I think Manage Localization would be more useful for language settings or something else like display timezone... 🤔

@jbrooksuk
Copy link
Member Author

Agreed! I'm going to close this PR and we can pick this up again.

@spoyntersmith do you fancy implementing the changes? 🎃

@jbrooksuk jbrooksuk closed this Oct 27, 2024
@jbrooksuk jbrooksuk deleted the localization-settings branch October 27, 2024 09:15
@spoyntersmith
Copy link

Agreed! I'm going to close this PR and we can pick this up again.

@spoyntersmith do you fancy implementing the changes? 🎃

Happy to! Could you add an issue and I will take a look 💪

@jbrooksuk
Copy link
Member Author

@spoyntersmith #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localization Settings
2 participants