-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved package init and publish flow #269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Negative feature comment is only blocker
Also, added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I completely missed these changes in my first pass: "Large diffs are not rendered by default." 🙄
When publishing either a package
Release
orInit
, a new errorConflictPendingPublish(RecordId)
may be returned.This instructs the client that it could wait for the conflicting pending record (on the same
LogId
package) to complete and then retry to publish.If a registry service offers key management and needs to sign the
Init
record, this enables a smoother experience and messaging on the CLI. Where the registry would return theRecordId
of the registry signedInit
record as aConflictPendingPublish
error, the CLI would wait for that record to publish and then retry. Since the package is already initialized, an error message would be presented that indicates that the package was initialized but not with theInit
record that you signed.Also, added a feature flag for
cli-interactive
for thewarg-client
and a config flag to disable dialoguer interactive prompting even when that feature is enabled.