Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resetting the default namespace on prefixed elements #96

Merged
merged 2 commits into from
Mar 22, 2019

Conversation

bwrrp
Copy link
Owner

@bwrrp bwrrp commented Mar 22, 2019

This fixes #86, which seems to be caused by a potential bug in the specification (filed as w3c/DOM-Parsing#48). Resetting the default namespace manually on an element that is not itself in that namespace seems like a valid use case. Testing in Firefox and Chrome does not result in an error being thrown. Let's follow their example here rather than the spec text.

@bwrrp bwrrp requested a review from DrRataplan March 22, 2019 10:11
@bwrrp bwrrp merged commit f99c1b4 into master Mar 22, 2019
@bwrrp bwrrp deleted the reset-default-namespace branch March 22, 2019 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsetting of default namespace breaks serialization to string
2 participants