New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update CI workflows version to v4 and node version to 20 #194

Merged

bvaughn merged 2 commits into bvaughn:master from sukvvon:chore/update-nvmrc-and-ci

Oct 13, 2024

Contributor

sukvvon commented Oct 13, 2024 •

edited

Loading

What:

update actions/checkout, pnpm/action-setup, actions/setup-nodes's verion to v4 in .github/workflows/ci.yml
update node version to 20 in .nvmrc

Why:

github actions is now using node version 20 but actions/checkout@v3, pnpm/action-setup@v2, actions/setup-nodes@v3 are using node verion 16 which is deprecated in github actions, so i update it all v4, you can see GitHub Actions: Transitioning from Node 16 to Node 20
update the node version to 20 for consistency with the node version of github actions

How:

we dont need to see warning message which is saying deprecated any more

Checklist:

Documentation
Tests
Ready to be merged

sukvvon added 2 commits

October 13, 2024 22:51


          chore(.github/workflows/ci.yml): update actions/checkout, pnpm/action…

094af24

…-setup, actions/setup-nodes v4


          chore(.nvmrc): update node version to 20

1349b3c

bvaughn merged commit 4aaf9b0 into bvaughn:master

3 checks passed

Owner

bvaughn commented Oct 13, 2024

Sure, thanks

sukvvon deleted the chore/update-nvmrc-and-ci branch

October 13, 2024 16:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet