-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per environment lamba configuration JSON files #304
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some docs explaining this, other than that, this is great!
@@ -53,11 +53,15 @@ export async function funcs (pattern = '*') { | |||
return funcs | |||
} | |||
|
|||
export async function lambdaConfig (name) { | |||
export async function lambdaConfig (name, env = null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When would you call this without specifying the env? If we never call it that way, might as well throw if either of these arguments are missing
@reconbot The only place that might call |
…ass the available env var too
….json configurations
I think it pays to have two more specific functions instead of an argument. Our code in general is a little overloaded so it's hard to reason when refactoring and that would make it easier. I really appreciate you putting eyes on all that. |
This PR allows shep to read
lambda.{env}.json
files in the project and function directories. This should allow more flexibility when deploying to VPCs in different environments, as well as using different runtimes (nodejs4.3, nodejs6.10, etc) in a dev environment before upgrading a prod environment.