Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont assume the new target function has an identifier, in case its a new variable getting set #302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

redterror
Copy link

I'm not sure this is entirely the right place for this, but it addresses the issue I had whereby doing:

$ shep config set FOO=bar

Would error with:

TypeError: Cannot read property 'Alias' of undefined
    at /home/dave/dev/lambda-alerts/node_modules/shep/lib/util/aws/lambda.js:115:42
    at next (native)
    at tryCatcher (/home/dave/dev/lambda-alerts/node_modules/bluebird/js/release/util.js:16:23)
    at PromiseSpawn._promiseFulfilled (/home/dave/dev/lambda-alerts/node_modules/bluebird/js/release/generators.js:97:49)
    at Async._drainQueue (/home/dave/dev/lambda-alerts/node_modules/bluebird/js/release/async.js:138:12)
    at Async._drainQueues (/home/dave/dev/lambda-alerts/node_modules/bluebird/js/release/async.js:143:10)
    at Immediate.Async.drainQueues (/home/dave/dev/lambda-alerts/node_modules/bluebird/js/release/async.js:17:14)
    at runCallback (timers.js:672:20)
    at tryOnImmediate (timers.js:645:5)
    at processImmediate [as _immediateCallback] (timers.js:617:5)

The bigger question is probably: why is updateFunction getting passed a partially initialized function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant