update docs for config set and remove #295
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reconbot
reviewed
Aug 31, 2017
README.md
Outdated
| @@ -73,17 +73,17 @@ By default shep builds all your functions using webpack. If your project require | |||
| ##### 1. Configure AWS | |||
| Since Shep uses the same credentials as the AWS CLI, all you need to do is configure the cli. This can be accomplished via `aws configure`. | |||
| ##### 2. Create a new Shep project | |||
| Run `shep new my-project` | |||
There was a problem hiding this comment.
the trailing spaces allow the newline to show in the rendered output
There was a problem hiding this comment.
my vscode auto trims whitespace 🤕
reconbot
reviewed
Aug 31, 2017
| @@ -4,7 +4,7 @@ import configSet from '../../config-set' | |||
| import * as load from '../../util/load' | |||
| import merge from 'lodash.merge' | |||
|
|
|||
| export const command = 'set <vars...>' | |||
There was a problem hiding this comment.
I'd make the env optional because it will ask you if you don't specify one. eg set [--env=<env>]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.