support fetching original package names and import paths via reflection #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function returns obfuscated names, so use that as its name. Moreover, some of the callers still called the result "objStr", which misled me into thinking the string was a unique object path. Leave a TODO behind about using go/types/objectpath too. Our own recordedObjectString is sort of similar, but not as principled.
Only two callers did pass nil, and there's no reason for them to do so. They should be the ones to check that typeToObj did not return nil.
There's no need to reach for sharedCache.ListedPackages when the caller is computePkgCache, which already has the lpkg value. While here, compare *go/types.Package pointers directly rather than via their import path strings.
Reflection can show package names alone via reflect.Type.String, and I'm sure they are available in other ways. We were obfuscating "package p" exactly like the import path "foo.com/p" which worked OK for the most part, but not for reflection. This is also a slight improvement to the quality of the obfuscation, given that package names and import paths will no longer be aligned when obfuscated.
lu4p
requested changes
Jan 5, 2025
obfuscatedImportPath already handled ToObfuscate, so the callers don't have to do that as well. Handle main packages too, whose logic was sprinkled and repeated throughout the project.
mvdan
force-pushed
the
reflect-pkgpath
branch
from
92638a6 to
d3baa51
Compare
|
Given that we don't agree on this, and that the approach as written doesn't fix Wails anyway, I'll need to give this a second attempt in a separate PR. For now, I have updated the PR to remove package name and path deobfuscation, and fixed a failing test as well. All of the changes leading up to the original reflect change are still valuable in my opinion, and should be merged. |
lu4p
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit messages - please do not squash)
Updates #849.