Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatible with go workspace mode #865

Merged
merged 1 commit into from
Aug 27, 2024
Merged

compatible with go workspace mode #865

merged 1 commit into from
Aug 27, 2024

Conversation

dydysy
Copy link
Contributor

@dydysy dydysy commented Aug 16, 2024

go: -mod may only be set to readonly or vendor when in workspace mode, but it is set to ""

go: -mod may only be set to readonly or vendor when in workspace mode, but it is set to ""
@mvdan
Copy link
Member

mvdan commented Aug 27, 2024

Thanks - I was trying to reset the -mod flag to its "unset" value, but as you point out, technically the empty string is not a valid value. The default behavior is "readonly" so I think this change is right. Since the change follows the docs, I don't think we need a test covering workspaces.

@mvdan mvdan enabled auto-merge (squash) August 27, 2024 08:11
@mvdan mvdan merged commit a99fbcb into burrowers:master Aug 27, 2024
5 checks passed
@dydysy dydysy deleted the patch-1 branch August 27, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants