-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NovoDataTablePagination): implement bare pagination theme #1280
Conversation
@adrianossi Is this in response to #1267? |
@adrianossi Can you fill out the description with what and why you are trying to accomplish? maybe even screenshot/mockup of the design error. |
@@ -628,6 +630,66 @@ novo-data-table-pagination { | |||
} | |||
} | |||
} | |||
&.bare { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is how we want to implement this.
- I think we want to move the
pagination
component to be a individualized component. ie. it should own its on styles. - we are trying to adopt a better naming convention for our classes, for example:
novo-date-table-bare-pagination
. but i don't think this is right anyways
@@ -64,6 +64,43 @@ const MAX_PAGES_DISPLAYED = 5; | |||
<span>{{ labels.next }}</span> | |||
</novo-button> | |||
</ng-container> | |||
<ng-container *ngIf="theme === 'bare'"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does it need a separate template?
Also can't you just use the emptyMessage template .... <ng-template novoTemplate="emptyMessage">
<entity-data-table-empty-message data-automation-id="category-table-add"
icon="ice-cream"
message="{{ 'CM.EMPTY_JOB_CODE' | translate }}"
label="{{ 'CM.ADD_JOB_CODE' | translate }}"
[permission]="canAdd"
(add)="openAddPage()"></entity-data-table-empty-message>
</ng-template> |
Description
Update NovoDataTablePagination with a "bare" theme that handles situations where the total number of records is unknown.
Verify that...
npm start
andnpm run build
still worksSafari
,Chrome
andFirefox
npm run lint
passesnpm test
passes and code coverage is increasednpm run build
still worksBullhorn Internal Developers
Novo Automation
Screenshots