PLAT-12127 add traceid to events #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
reviewed
May 17, 2024
| } | ||
|
|
||
| Log("Parsing result to CorrelationTransfer"); | ||
| var performanceState = JsonUtility.FromJson<PerformanceState>(result); |
There was a problem hiding this comment.
What happens if we ever have to change the structure of this for some reason? Would it gracefully handle the change, or would customers have to lockstep upgrade both the notifier and the performance library to avoid a crash?
|
I really think that we should version these kinds of cross-library interfaces so that we don't accidentally paint ourselves into a corner... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE
This PR is part of work connected to the Unity Notifier, the sister PR can be found here: bugsnag/bugsnag-unity-performance#112
Please do not review this PR without also reviewing the other
Goal
When a C# layer error occurs, get the current span context from the Unity Performance SDK and include it in the event report.
Changeset
Added PerformanceHelper class to get information from the Performance SDK if it is present.
Testing
Manually tested
E2E Tests will be added in a later task