Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-12109 add bugsnag integity header #797

Merged
merged 2 commits into from
May 10, 2024
Merged

Conversation

richardelms
Copy link
Contributor

@richardelms richardelms commented May 8, 2024

Goal

add bugsnag integity header

Testing

Covered by existing mazerunner tests

@richardelms richardelms self-assigned this May 8, 2024
@richardelms richardelms changed the title header ready for testing PLAT-12109 add bugsnag integity header May 10, 2024
@richardelms richardelms marked this pull request as ready for review May 10, 2024 07:08
@bugsnagbot
Copy link
Collaborator

Build size impact

Format Size impact of Bugsnag (kB)
IL2CPP APK 2442.76
IL2CPP IPA 1507.36

Generated by 🚫 Danger

@twometresteve
Copy link
Contributor

twometresteve commented May 10, 2024

I'd suggest running the full CI pipeline to verify that WebGL behaviour is correct and tests pass.

Copy link
Contributor

@twometresteve twometresteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twometresteve
Copy link
Contributor

Actually, should there be a CHANGELOG entry for this?

@richardelms richardelms merged commit 6f1cb44 into next May 10, 2024
40 of 41 checks passed
@richardelms richardelms deleted the 12109-intergrityHeader branch May 10, 2024 10:13
@richardelms richardelms mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants