Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bugsnag-android v6.5.0 #766

Merged
merged 16 commits into from
Jun 3, 2024
Merged

Update bugsnag-android v6.5.0 #766

merged 16 commits into from
Jun 3, 2024

Conversation

clr182
Copy link
Contributor

@clr182 clr182 commented Jan 10, 2024 •
edited by richardelms
Loading

Goal

Update version of bugsnag-android to v6.5.0

Changeset

  • Updated Rakefile to remove call to obsolete bugsnag-android-ndk
  • Updated native handling of thread.id, changing from an int to a string
  • Changed redactedKeys and discardClasses to regex patterns when transfering to the native side.

Testing

Covered by existing e2e tests

@clr182 clr182 self-assigned this Jan 10, 2024
@richardelms richardelms self-requested a review January 10, 2024 12:56
@clr182 clr182 marked this pull request as draft February 6, 2024 10:36
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Feb 6, 2024 •
edited
Loading

Build size impact

Format Size impact of Bugsnag (kB)
IL2CPP APK 2438.53
IL2CPP IPA 1507.79

Generated by 🚫 Danger

@richardelms richardelms self-assigned this May 31, 2024
@richardelms richardelms marked this pull request as ready for review May 31, 2024 11:20
@richardelms richardelms requested review from twometresteve and removed request for richardelms May 31, 2024 11:21
@richardelms richardelms requested a review from YYChen01988 May 31, 2024 11:22
@twometresteve twometresteve changed the title Update bugsnag-android v6.1.0 Update bugsnag-android v6.5.0 May 31, 2024
@twometresteve
Copy link
Contributor

I've changed the PR title to read 6.5.0 rather than 6.1.0 - I assume that was the right thing to do.

YYChen01988
YYChen01988 approved these changes May 31, 2024
View reviewed changes
Copy link

@YYChen01988 YYChen01988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending CI

twometresteve
twometresteve approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@twometresteve twometresteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks fine, I just have some questions about testing and docs, if we can have a quick chat IRL when convenient.

@richardelms richardelms merged commit c83ddfc into next Jun 3, 2024
42 checks passed
@richardelms richardelms deleted the BumpsnagAndroid6 branch June 3, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YYChen01988 YYChen01988 YYChen01988 approved these changes

@twometresteve twometresteve twometresteve approved these changes

Assignees

@richardelms richardelms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clr182 @bugsnagbot @twometresteve @YYChen01988 @richardelms