♻️ workshops landing when logged in #1765
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
tommygonzaleza
approved these changes
Jan 7, 2025
tommygonzaleza
requested changes
Jan 17, 2025
…velopment-lumi-7608
… into development-lumi-7608
tommygonzaleza
approved these changes
Jan 29, 2025
… into development-lumi-7608
tommygonzaleza
requested changes
Jan 30, 2025
Comment on lines
270
to
282
| {date?.ended && ( | ||
| t('watch-recording') | ||
| )} | ||
| {date?.started && !date?.ended && ( | ||
| t('join-workshop') | ||
|
|
||
| )} | ||
| {!date?.started && !date?.ended && ( | ||
| t('register-workshop') | ||
| )} | ||
| {date?.started && ( | ||
| <Icon icon="longArrowRight" width="24px" height="10px" color="currentColor" /> | ||
| )} |
There was a problem hiding this comment.
These are nested conditions and we should avoid them inside the JSX. Instead, we should create a function before the return of this component, that returns the JSX with the conditions inside determining what to return
tommygonzaleza
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: breatheco-de/breatheco-de#7608
Related Issue: breatheco-de/breatheco-de#8392