Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom the barcode #262

Open
bracuphoth opened this issue Aug 2, 2018 · 5 comments
Open

Zoom the barcode #262

bracuphoth opened this issue Aug 2, 2018 · 5 comments

Comments

@bracuphoth
Copy link

I installed the app on a 8" screen tablet. And I discovred that even the portrait version is way too big for the scanner. With a 5" telephone screen everything works fine.

@brarcher
Copy link
Owner

brarcher commented Aug 3, 2018

Hm. So the barcode can be too big. Right now there is a max width 1500 pixels for 1D barcodes as 500 pixels for 2D barcodes. Maybe that is still too big for some devices.

Can you tell me what kind of device you have? I can create a simulator and see what you are seeing.

@bracuphoth
Copy link
Author

It's a Kindle Fire 8", the 2017 model

@OmlineEditor
Copy link

Add the ability to resize the barcode. This is a very useful and necessary feature. Now the size of the barcode is very large. The barcode size must be calculated based on the screen size in pixels and the pixel density (dots per inch) on the screen. then the size on all devices will be the same. add a new function to change the size of the barcode and calculate it using the formula

@clach04
Copy link

clach04 commented Jan 18, 2020

I've linked a few issues where if there was a manual zoom (maybe ideally pinch, but plus/minus zoom buttons might help) some of these issues would have at worst a workaround and in some cases final solution.

I agree it would be cool if there was code to handle DPI but manual override would solve multiple issues. Does this warrant a new issue/enhancement request?

  • manual zoom
  • improved automatic zoom that is DPI/real-world aware

@TheLastProject
Copy link
Contributor

I think a new issue for DPI may be best, and just leaving this for zooming. Worst case scenario, one pull request can solve both issues if they end up being "too related". In my honest opinion, at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants