Landscape view not usable on some devices

[TheLastProject]

Issue by callegar
Monday Feb 26, 2018 at 21:05 GMT
Originally opened as brarcher/loyalty-card-locker#212

---

On my Samsung S5 mini, the rotated, landscape view has become unusable on recent versions of the application. This is because the card title is too tall, not leaving enough space to the barcode, that ends up as large as the screen width, but only a couple of mm tall, which is insufficient for reliable scanning.

[TheLastProject]

Comment by brarcher
Tuesday Feb 27, 2018 at 01:52 GMT

---

I recently created a change which reduces the size of the header for the title, but find that I did not merge it in yet. That change is brarcher/loyalty-card-locker#213. I took a look at that change with the emulator for small screen sizes, and think that it improves the 1D barcode display.

Attached is a build with that change:
loyalty-card-locker.apk.zip

Would you mind trying it out and seeing if it makes the 1D barcodes usable on your device and provide feedback? If you still see an issue, could you post a screen capture of a barcode so I can see what you are observing? You need not post a screen shot of a real barcode, you can make up and entry.

[TheLastProject]

Comment by shapirus
Wednesday Feb 28, 2018 at 10:39 GMT

---

I've had this issue on my Huawei Ascend P6S also. I tried to install the APK you provided above (for some reason it refused to install as an upgrade on top of the version installed by f-droid, so I had to remove, install and restore data from backup), and it does improve things. The barcode height in landscape view looks usable now, please see the attached image (the ruler scale is centimeters). It might still be increased a little further, I think.

[TheLastProject]

Comment by callegar
Wednesday Feb 28, 2018 at 11:13 GMT

---

Same sensations as those from shapirus here. Also IMHO, the height of the barcode in landscape mode could be increased more. My feeling is that in landscape the barcode should really take at least half of the screen height, leaving about 1/3 for the card name and description on top and 1/6 for the stuff encoded on the barcode at the bottom.

[TheLastProject]

Comment by brarcher
Thursday Mar 01, 2018 at 03:47 GMT

---

for some reason it refused to install as an upgrade on top of the version installed by f-droid

This is because I do not have the signing key that the F-Droid project uses. The key I sign with is the same key as is used for the APK available on the releases page and on Google Play.

Thanks for the feedback on the landscape layout. I'll push the changes that were in the APK mentioned above into a release. After, I'll look into further improving the landscape layout.

[TheLastProject]

Comment by clach04
Saturday Jan 18, 2020 at 22:48 GMT

---

If ssue #262 is implemented it may help with this.

[TheLastProject]

I think 0bb0df2 should fix this. Feel free to reopen if you disagree.