e2e: don't pass client via globvar #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stlaz
force-pushed
the
e2e_kubeconfig
branch
from
10b0a23 to
16041f1
Compare
ibihim
reviewed
Nov 25, 2024
go.mod
Outdated
| @@ -8,6 +8,7 @@ require ( | |||
| github.com/oklog/run v1.1.0 | |||
| github.com/spf13/cobra v1.8.1 | |||
| github.com/spf13/pflag v1.0.5 | |||
| github.com/stretchr/testify v1.9.0 | |||
There was a problem hiding this comment.
Oh dear God, please no no no no no.
stlaz
force-pushed
the
e2e_kubeconfig
branch
from
16041f1 to
c21fb0e
Compare
Use the kube-native way to construct a client by using the KUBECONFIG env var. That was done in the tests anyway (see the change to the Makefile).
stlaz
force-pushed
the
e2e_kubeconfig
branch
from
c21fb0e to
7774c73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the kube-native way to construct a client by using the KUBECONFIG env var. That was done in the tests anyway (see the change to the Makefile).
The current system promotes using globvars which is a malpractice that should be avoided. It's only confusing new contributors. Let's remove it and just use the KUBECONFIG variable as in the rest of the Kubernetes ecosystem.