Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code refactoring #121

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+83 −70
Open

code refactoring #121

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
449703f
add method connectURl to Configuration method from OAuthGateway - Move
sksaifuddin Apr 6, 2023
5927f1f
refactoring complex condition in Crypto class
sksaifuddin Apr 6, 2023
7c55b6e
refactored complex method in Customer class - extract method refactoring
sksaifuddin Apr 6, 2023
741e351
refactored update method in MerchantAccountGateway class - introducin…
sksaifuddin Apr 6, 2023
762b7ab
created a new class to remove the duplicate code from Sha1 and Sha256…
sksaifuddin Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactored update method in MerchantAccountGateway class - introducin… 
…g explaining variable refactoring
@sksaifuddin
sksaifuddin committed Apr 6, 2023
commit 741e351ff48b8af9ff3fa068351e0206b594be07
3 changes: 2 additions & 1 deletion src/main/java/com/braintreegateway/MerchantAccountGateway.java
View file
Original file line number Diff line number Diff line change
@@ -37,7 +37,8 @@ public MerchantAccount find(String id) {
}

public Result<MerchantAccount> update(String id, MerchantAccountRequest request) {
final NodeWrapper response = http.put(configuration.getMerchantPath() + "/merchant_accounts/" + id + "/update_via_api", request);
String updateUrl = "/merchant_accounts/" + id + "/update_via_api";
final NodeWrapper response = http.put(configuration.getMerchantPath() + updateUrl, request);
return new Result<MerchantAccount>(response, MerchantAccount.class);
}