Braintree java issue 119

[kmichalak]

Summary

Checklist

• Added changelog entry
• Ran unit tests (mvn verify -DskipITs)
• I understand that unless this is a Draft PR or has a DO NOT MERGE label, this PR is considered to be in a deploy ready state and can be deployed if merged to main

[hollabaq86]

Thanks @kmichalak! We;ll take a look and provide feedback is needed.

For internal tracking, issue 7173

[saralvasquez]

This looks really great @kmichalak. Thank you for putting this together! Just a couple nits

[kmichalak]

Thanks @saralvasquez for pointing that out. I've done necessary updates. This should be find now I guess?

[saralvasquez]

@kmichalak thanks for that update! We'll give it a final pass and get it pulled in

[saralvasquez]

Hi! Sorry this process has taken so long. My team and I have been discussing this issue for a while since it's a lot more complicated than it initially seemed. Ultimately, we concluded that we can't pull in these changes. I will post a detailed explanation in the open GitHub issue, but the TLDR of it is that these changes would break user integrations by changing the base functionality of the generate method. We have to assume users aren't set up to automatically handle new exceptions thrown when the generate call would normally just return null. In order to stay in line with semantic versioning, we can't break users' integrations unless we put out a new major version, which we don't have the bandwidth for at the moment. We do plan on changing how client token generation handles nonexistent customers in all of the SDKs and we will find a way to credit you in the Java SDK when the next major version comes out. Thank you so much for putting in this work! We're really sorry it won't be used just yet.