Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create threeDSecure encodable #1515

Merged
merged 30 commits into from
Mar 3, 2025
Merged

Create threeDSecure encodable #1515

merged 30 commits into from
Mar 3, 2025

Conversation

warmkesselj
Copy link
Contributor

@warmkesselj warmkesselj commented Feb 5, 2025 •
edited
Loading

Summary of changes

Transition to use a ThreeDSecure Encodable body for the post parameters.

Checklist

  • Added a changelog entry
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

@warmkesselj
@jwarmkessel

@warmkesselj warmkesselj changed the base branch from main to v7 February 5, 2025 22:00
@warmkesselj
Merge branch 'v7' of https://github.com/braintree/braintree_ios into …
a45ddc6 
…create-encodable-three_d_secure-encodable

# Conflicts:
#	Braintree.xcodeproj/project.pbxproj
@warmkesselj
Update project file
929f9fa
@warmkesselj warmkesselj marked this pull request as ready for review February 5, 2025 22:13
@warmkesselj warmkesselj requested a review from a team as a code owner February 5, 2025 22:13
jaxdesmarais
jaxdesmarais approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of very minor comments but approving ahead of time

@warmkesselj warmkesselj merged commit d7b1bf8 into v7 Mar 3, 2025
6 of 7 checks passed
@warmkesselj warmkesselj deleted the create-encodable-three_d_secure-encodable branch March 3, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scannillo scannillo scannillo left review comments

@stechiu stechiu stechiu left review comments

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

@richherrera richherrera richherrera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@warmkesselj @jaxdesmarais @scannillo @stechiu @richherrera