Remove Activity from PayPalClient

[sarahkoop]

Summary of changes

• Remove FragmentActivity parameter from PayPalClient methods in favor of Context
• Move assertCanPerformBrowserSwitch from PayPalClient to PayPalLauncher since the launcher handles starting the browser switch now

Checklist

• [ ] Added a changelog entry

Authors

• @sarahkoop

[tdchow]

Changes look good 👍 Just curious, was there a need to previously take in a FragmentActivity?

[sarahkoop]

Changes look good 👍 Just curious, was there a need to previously take in a FragmentActivity?

The device inspector methods take in a FragmentActivity parameter currently, but I think the client methods always could have passed Context instead. More PRs to come to update everything to the more generic ComponentActivity where an activity is needed since I don't think we ever used the FragmentActivity specific attributes.

[sshropshire]

@tdchow @sarahkoop Happy New Year y'all!

2cents: Any need for an Activity reference is usually tied to allowing the Chrome Custom Tab to launch in the same task. The "launcher" pattern we've been introducing should make Feature Clients only need a Context to access shared prefs, etc. which would be really clean.