Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local Payment Single Result Object #851

Merged
merged 16 commits into from
Dec 13, 2023
Merged

Local Payment Single Result Object #851

merged 16 commits into from
Dec 13, 2023

Conversation

sarahkoop
Copy link
Contributor

Summary of changes

  • Add single result object pattern to Local Payment module
  • Fix demo app to allow using tokenization key (to test local payment)
  • Renamed existing two parameter callbacks to "internal" - to be updated in the future when we switch to single result objects internally as well as publicly

Checklist

  • Added a changelog entry

Authors

@sarahkoop sarahkoop requested a review from a team as a code owner December 12, 2023 16:34
tdchow
tdchow reviewed Dec 12, 2023
View reviewed changes
v5_MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
v5_MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
@sarahkoop sarahkoop merged commit 0deb12d into v5 Dec 13, 2023
2 checks passed
@sarahkoop sarahkoop deleted the local_payment_single_result branch December 13, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshropshire sshropshire sshropshire approved these changes

@tdchow tdchow tdchow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarahkoop @tdchow @sshropshire