-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Card FPTI Analytics Events #850
Conversation
} | ||
} else if (exception != null) { | ||
callback.onCardResult(new CardResult.Failure(exception)); | ||
braintreeClient.sendAnalyticsEvent("card.nonce-failed"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were these existing events already being sent to FPTI? Just want to make sure that this change doesn't break any existing reports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know, there aren't any existing reports that are based on the old events, and the new dashboards will be based on these new planned events - but @scannillo correct me if I'm wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great question. So on this V5 branch, we already merged in a change that sends our analytics directly to FPTI versus sending to the old BT analytics service (Arachne).
The old events weren't being used in any dashboard, but these new events now mirror the ones on BT iOS V6, and will be able to be used in our new conversion dashboard that we share b/w BT & PPCP mobile.
With Android V5, we're doing this analytics cleanup to keep things consistent across platform & product
Card/src/test/java/com/braintreepayments/api/CardClientUnitTest.java
Outdated
Show resolved
Hide resolved
…t.java Co-authored-by: scannillo <[email protected]>
Summary of changes
Checklist
[ ] Added a changelog entryAuthors