Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Card FPTI Analytics Events #850

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Add Card FPTI Analytics Events #850

merged 4 commits into from
Dec 12, 2023

Conversation

sarahkoop
Copy link
Contributor

Summary of changes

  • Update card tokenize analytics with new FPTI events

Checklist

  • [ ] Added a changelog entry

Authors

@sarahkoop sarahkoop requested a review from a team as a code owner December 11, 2023 19:27
}
} else if (exception != null) {
callback.onCardResult(new CardResult.Failure(exception));
braintreeClient.sendAnalyticsEvent("card.nonce-failed");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were these existing events already being sent to FPTI? Just want to make sure that this change doesn't break any existing reports.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, there aren't any existing reports that are based on the old events, and the new dashboards will be based on these new planned events - but @scannillo correct me if I'm wrong.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great question. So on this V5 branch, we already merged in a change that sends our analytics directly to FPTI versus sending to the old BT analytics service (Arachne).

The old events weren't being used in any dashboard, but these new events now mirror the ones on BT iOS V6, and will be able to be used in our new conversion dashboard that we share b/w BT & PPCP mobile.

With Android V5, we're doing this analytics cleanup to keep things consistent across platform & product

@sarahkoop sarahkoop merged commit 215b24e into v5 Dec 12, 2023
@sarahkoop sarahkoop deleted the card_fpti branch December 12, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants